[MRG] Fix small papercuts: SyntaxWarning and coverage reports #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
excellent, the first one has been bothering me too 😆 |
ctb
approved these changes
Apr 28, 2021
Codecov Report
@@ Coverage Diff @@
## latest #1488 +/- ##
==========================================
+ Coverage 89.76% 94.89% +5.13%
==========================================
Files 123 96 -27
Lines 19553 15930 -3623
Branches 1497 1497
==========================================
- Hits 17552 15117 -2435
+ Misses 1775 587 -1188
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two things that are bothering me when running tests:
SyntaxWarningfor usage ofisinstead of==when checking for equalitytox -e coverageif needed (or in codecov when the PR is updated)